CaselIT
commented
4 years ago Could you expand how would this would work? In particular:
- What would the parameters be?
- Should it be called in case of errors? If we decide only when the request has success, maybe the name should be
on_success? - Should it respect the
independent_middlewareflag? - Can a middleware send a custom response to the server, allowing it to short circuit the rest of the normal processing of the api? i guess that in this case the interfaces for the wsgi and asgi calls would need to be different. Also what should we do if two middleware try do return a custom response?
I guess the location of the call in the application would after the lines here
If the objective is to support mainly the last point, maybe it would be simpler to detach if from the middleware, and have something similar to the add_error_handler, something like a add_success_handler or similar, that accepts a single function that could return a custom response to the server. I'm not sure if we should accept multiple functions, that are called one after the other, in order, where the first that returns a custom response would "win" and the processing of the other function would end, along with the processing of the rest of the application.
Something like
for handler in self._success_handlers:
body= handler(req, res, ...) # what other parameters should be pass?
if body is not None:
return body
vytas7
kgriffs
Implement an additional
on_finalize()middleware method for ASGI and WSGI that is called immediately before the response body is returned to the server. This can be used by apps to implement protocol extensions (e.g., server push).