search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

fix(ASGI): assume ISO-8859-1 for ASGI headers #1914

Closed vytas7 closed 3 years ago

vytas7 commented 3 years ago

Closes #1911

codecov[bot] commented 3 years ago

Codecov Report

Merging #1914 (7ceb7a5) into master (e1ebdb7) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1914   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6593      6610   +17     
  Branches      1065      1067    +2     
=========================================
+ Hits          6593      6610   +17
Impacted Files Coverage Δ
falcon/asgi/_request_helpers.py 100.00% <100.00%> (ø)
falcon/asgi/request.py 100.00% <100.00%> (ø)
falcon/asgi/response.py 100.00% <100.00%> (ø)
falcon/testing/helpers.py 100.00% <100.00%> (ø)
falcon/util/misc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1ebdb7...7ceb7a5. Read the comment docs.

vytas7 commented 3 years ago

I realized I probably need to add a couple more regression tests for the reported issue itself. Working on this now.

Edit: done now.