falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.

https://falcon.readthedocs.io/en/stable/

Apache License 2.0

9.53k stars 945 forks source link

chore(CI): add CPython 3.10 gates #1922

Closed vytas7 closed 3 years ago

vytas7 commented 3 years ago

I haven't added the corresponding Trove classifier yet, waiting for @CaselIT 's PEP 517 changes to land, as well as for 3.10 itself to stabilize.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1922 (e54988e) into master (cf6dc45) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1922   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6621      6621           
  Branches      1067      1067           
=========================================
  Hits          6621      6621

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf6dc45...e54988e. Read the comment docs.

CaselIT commented 3 years ago

Why don't we also migrate the bulk of the tests to 3.9 from 3.8?

vytas7 commented 3 years ago

We should, but that's a separate issue I believe.

vytas7 commented 3 years ago

Moving to Draft; it seems there is an issue with the websockets client (or our usage pattern thereof) on 3.10.

The issue seems, itself, to be fixed, but I haven't checked whether we just need to wait for a new release, or refactoring of our usage patterns is needed.

Edit: tried using websockets from their latest commit on GH, still the same. So this is still blocked.