search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.53k stars 945 forks source link

feat(typing): add type hints to compiled router #1944

Closed CaselIT closed 4 months ago

CaselIT commented 3 years ago

This is mainly to try how cython works with pep484 types

NOTE: this is currently unmergiable, since it's not py 3.5 compatible

Gist with the compilations with cython https://gist.github.com/CaselIT/f0493d74422cce46c95c10e8abd1e4f0

codecov[bot] commented 3 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (09189a8) to head (325f2af).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1944 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 6847 6847 Branches 1258 1258 ========================================= Hits 6847 6847 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vytas7 commented 2 years ago

This should be good to revisit again once https://github.com/falconry/falcon/pull/1947 gets merged.

vytas7 commented 1 year ago

@CaselIT Now we can continue with this one; we just need to address merge conflicts and it may possible to move this forward off Draft.

CaselIT commented 1 year ago

I'll try getting into it soonish