falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

fix(asgi): Incomplete, add finally to stream close #1948

Closed dimucciojonathan closed 3 years ago

dimucciojonathan commented 3 years ago

Summary of Changes

@vytas7

Related Issues

1943

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

dimucciojonathan commented 3 years ago

Error Message:

================================================= short test summary info ================================================= FAILED tests/asgi/test_hello_asgi.py::TestHelloWorld::test_filelike_closing_aiofiles - assert False FAILED tests/asgi/test_hello_asgi.py::TestHelloWorld::test_filelike_closing[DataReader-True] - assert False ========================== 2 failed, 3088 passed, 168 skipped, 16 warnings in 192.20s (0:03:12) =========================== ERROR: InvocationError for command /Users/a1425/Documents/python-files/falcon-repo/falcon/.tox/py38/bin/coverage run -m pytest tests (exited with code 1)

codecov[bot] commented 3 years ago

Codecov Report

Merging #1948 (7a355e1) into master (e255bff) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6610      6610           
  Branches      1067      1067           
=========================================
  Hits          6610      6610           
Impacted Files Coverage Δ
falcon/asgi/app.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e255bff...7a355e1. Read the comment docs.