Closed dimucciojonathan closed 3 years ago
Error Message:
================================================= short test summary info ================================================= FAILED tests/asgi/test_hello_asgi.py::TestHelloWorld::test_filelike_closing_aiofiles - assert False FAILED tests/asgi/test_hello_asgi.py::TestHelloWorld::test_filelike_closing[DataReader-True] - assert False ========================== 2 failed, 3088 passed, 168 skipped, 16 warnings in 192.20s (0:03:12) =========================== ERROR: InvocationError for command /Users/a1425/Documents/python-files/falcon-repo/falcon/.tox/py38/bin/coverage run -m pytest tests (exited with code 1)
Merging #1948 (7a355e1) into master (e255bff) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1948 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6610 6610
Branches 1067 1067
=========================================
Hits 6610 6610
Impacted Files | Coverage Δ | |
---|---|---|
falcon/asgi/app.py | 100.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e255bff...7a355e1. Read the comment docs.
Summary of Changes
@vytas7
finally
clause was added tofalcon/asgi/app.py
, so that the stream is closed even when an exception occurs.tests/asgi/test_hello_asgi.py
, which are related to closing of the file. Assistance / guidance from an expert is needed.Related Issues
1943
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)