falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

feat(routing): support range requests for static routes #1959

Closed tipabu closed 2 years ago

tipabu commented 2 years ago

Summary of Changes

Add support for Range requests to static routes:

Related Issues

Closes #1858

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

codecov[bot] commented 2 years ago

Codecov Report

Merging #1959 (c49171a) into master (9ff7710) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6624      6669   +45     
  Branches      1068      1079   +11     
=========================================
+ Hits          6624      6669   +45     
Impacted Files Coverage Δ
falcon/request.py 100.00% <100.00%> (ø)
falcon/routing/static.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ff7710...c49171a. Read the comment docs.

CaselIT commented 2 years ago

thanks for the pr. I'll try to review shorlty

tipabu commented 2 years ago

Makes sense, sorry. Yeah, I'm coming more from gerrit, where ammending a commit and resubmitting is the norm. Good news is that the "force-pushed" text above links to https://github.com/falconry/falcon/compare/7e059b2f22a00406a8222fa8a60c8aad88293ade..a6fb3e0166f5a063deac1cb7bf256ff67b98b941 to just see the delta, but I think I've had problems with that in the past where github wouldn't know how to find the old commit.