falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

Implement FloatConverter #2022

Closed vytas7 closed 2 years ago

vytas7 commented 2 years ago

Implement FloatConverter along the lines of IntConverter. Draw inspiration from IntConverter, or even find an efficient way to share code between the two!

Add the new converter to the list of Built-in Converters under the float identifier.

Open questions: should we support converting nan, inf & -inf from path?

Rangeeshar commented 2 years ago

Hi, @vytas7 I am picking up this task for adding float converter, Do let me know if any pointers to keep in mind while doing so.

vytas7 commented 2 years ago

Hi @Rangeeshar! There is already an open pull request implementing this feature: https://github.com/falconry/falcon/pull/2026. Could you coordinate with @meetshah133 ?