search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.53k stars 945 forks source link

fix(asgi.stream): no longer hang upon last empty body chunk #2027

Closed vytas7 closed 2 years ago

vytas7 commented 2 years ago

Fixes #2024

codecov[bot] commented 2 years ago

Codecov Report

Merging #2027 (7ec1be2) into master (8702f2d) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2027   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6715      6714    -1     
  Branches      1243      1243           
=========================================
- Hits          6715      6714    -1
Impacted Files Coverage Δ
falcon/asgi/stream.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8702f2d...7ec1be2. Read the comment docs.

vytas7 commented 2 years ago

devil's in the details! should we backport to 3.0.1 and release a 3.0.2?

That's a good idea @CaselIT; let's discuss it on Gitter. Another alternative is just pushing out 3.1 since it's well overdue too! :shipit: