Closed RioAtHome closed 2 years ago
Merging #2046 (699eba9) into master (dc67205) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #2046 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6707 6715 +8
Branches 1242 1243 +1
=========================================
+ Hits 6707 6715 +8
Impacted Files | Coverage Δ | |
---|---|---|
falcon/testing/client.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc67205...699eba9. Read the comment docs.
This is shaping up! Should we also add a towncrier newsfragment for this improvement?
towncrier newsfragment? Sorry to be a bother, but any pointers on what this is?, and where to start if i want to add it?
towncrier newsfragment?
It's just a few words that should appear on the changelog. See other newsfragments here https://github.com/falconry/falcon/tree/master/docs/_newsfragments and this section of the contributing file https://github.com/falconry/falcon/blob/master/CONTRIBUTING.md#changelog
@CaselIT Thanks for the replying. I like to point out that the link to towncrier in the changelog section of the contributing file does not work.
Unfortunately towncrier isn't particularly well maintained; we're looking for alternatives, but I don't know when the change could actually happen.
Anyway, I'll update the link to https://towncrier.readthedocs.io/, that should be fixed as per https://github.com/twisted/towncrier/issues/367 (although it still says 17.08
in the title? :thinking:)
Hello, sorry to be a bother, but can i get a review on this pull request?
my latest commit changes:
Result.__repr__
will not show any None
values.Result.__repr__
shows a total of 40 bytes of Result.content where it takes the first 20 and the last 20 and ellipsize the rest with ...
.Result.__repr__
tests, mainly removed duplicate code (the get and post methods).
Summary of Changes
Added
__repr__
totesting.Result
, where it shows the status code, content-type header and first 20 char. Also added a simple test.Related Issues
Issue #2044
Pull Request Checklist
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)PR template inspired by the attrs project.