Closed kgriffs closed 2 years ago
Merging #2063 (f6f6c4a) into master (47e3e16) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #2063 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6715 6722 +7
Branches 1242 1244 +2
=========================================
+ Hits 6715 6722 +7
Impacted Files | Coverage Δ | |
---|---|---|
falcon/asgi/request.py | 100.00% <100.00%> (ø) |
|
falcon/request.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 47e3e16...f6f6c4a. Read the comment docs.
@kgriffs you forgot to commit the news fragment
Summary of Changes
This patch adds a
headers_lower
property to provide a unified way to get all headers lowercased for middleware, etc. that needs to be compatible with both WSGI and ASGI. This was done in lieu of introducing a breaking change to the WSGIheaders
property.Related Issues
N/A
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.