falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.

https://falcon.readthedocs.io/en/stable/

Apache License 2.0

9.51k stars 937 forks source link

chore(CI): make sure Mailman tests run under CPython 3.8 #2069

Closed vytas7 closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #2069 (89a50d9) into master (fe5f94b) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2069   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6707      6707           
  Branches      1242      1242           
=========================================
  Hits          6707      6707

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe5f94b...89a50d9. Read the comment docs.

vytas7 commented 2 years ago

I modified one file to skip the only (or so I thought) failing test, but now something else is failing... So this will have to wait for @maxking I guess :imp:

CaselIT commented 2 years ago

I modified one file to skip the only (or so I thought) failing test, but now something else is failing... So this will have to wait for @maxking I guess 👿

alternatively you can patch away tests until there are no more failures :)

vytas7 commented 2 years ago

I can recursively remove all test_*.py, then it should almost definitely pass 😁

vytas7 commented 2 years ago

Okay, so I was digging into this a bit more in depth, and the problem was more mundane than that.

The failures were caused by tox picking python3.10, so I simply specified basepython = python3.8, and voila: https://github.com/falconry/falcon/runs/6545473611?check_suite_focus=true.