falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

CONTRIBUTING.md: Fix typo #2091

Closed cclauss closed 2 years ago

cclauss commented 2 years ago

Summary of Changes

Replace this text with a high-level summary of the changes included in this PR.

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

codecov[bot] commented 2 years ago

Codecov Report

Merging #2091 (2824ce4) into master (5771bfc) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2091   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6752      6752           
  Branches      1254      1254           
=========================================
  Hits          6752      6752           
Impacted Files Coverage Δ
falcon/util/sync.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CaselIT commented 2 years ago

that fail on pep8 is not due to flake8 v5 that became better at finding errors, and is otherwise unrelated to this PR

cclauss commented 2 years ago

The flake8 error was a long line.

CaselIT commented 2 years ago

Thanks for fixing that!