search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

Replace the obsolete JS media type #2110

Closed euj1n0ng closed 1 year ago

euj1n0ng commented 2 years ago

RFC-4329 is obsolete.

According to RFC-9239,

vytas7 commented 2 years ago

Thanks for heads up @euj1n0ng!

Falcon isn't heavily tied to Javascript, so I suppose this is just about updating constants.py::MEDIA_JS. Would you like to create a PR?

MS-Ignis commented 1 year ago

Hey, this is my first time contributing to open source. Is this issue still open? @vytas7 @euj1n0ng Also will this contribute to hacktoberfest?

euj1n0ng commented 1 year ago

Hey, this is my first time contributing to open source. Is this issue still open? @vytas7 @euj1n0ng Also will this contribute to hacktoberfest?

The relevant PR: https://github.com/falconry/falcon/pull/2111 The motivation: https://github.com/WebOfTrust/keripy/pull/316

vytas7 commented 1 year ago

Aha, I was unaware of the context. In fact, we need to check if this type constant is actually enforced when serving static files, otherwise you'll need to submit a PR to the CPython (or PyPy) interpreter itself :slightly_smiling_face:

(Or we need to modify Falcon to prioritize these constants vs the system's mimetypes -- take a look at response.py:1246 if you want to update your PR in this vein.)

harshashetty67 commented 1 year ago

Hi all, is this issue fixed? if not, I would like to contribute. I'm new to open source and was looking for good first issues. @vytas7 @euj1n0ng

vytas7 commented 1 year ago

Hi @harshashetty67, this is not fixed, but there is already an open PR.

@harshashetty67 if you are okay with contributing documentation, we have a bunch of good first issues. We don't have that many good first issues for coding at the moment... You can view all issues that need a contributor here: https://github.com/falconry/falcon/issues?q=is%3Aopen+is%3Aissue+label%3A%22needs+contributor%22 Maybe one of these could suit you?

And as said, if you're fine with writing documentation, then we have tons of good first issues. I can help you picking something there.

Edit: somewhere between coding and docs, the following one would be a nice addition IMHO: https://github.com/falconry/falcon/issues/1355