feat: replace obsolete JS media type

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.

https://falcon.readthedocs.io/en/stable/

Apache License 2.0

9.51k stars 937 forks source link

feat: replace obsolete JS media type #2111

Closed euj1n0ng closed 1 year ago

euj1n0ng commented 2 years ago

Summary of Changes

A minor fix according to RFC 9239 - Updates to ECMAScript Media Types

Related Issues

Closes #2110

codecov[bot] commented 2 years ago

Codecov Report

Merging #2111 (5dda080) into master (c7c790f) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6802      6805    +3     
  Branches      1097      1098    +1     
=========================================
+ Hits          6802      6805    +3

Impacted Files	Coverage Δ
falcon/constants.py	`100.00% <100.00%> (ø)`
falcon/response.py	`100.00% <100.00%> (ø)`

kgriffs commented 1 year ago

@vytas7 I can add the news fragment after this is merged if we want to just move forward with this.

vytas7 commented 1 year ago

@kgriffs another problem is that this PR, while good-to-go from our side, would probably not address the issue the author had at hand. I wrote a comment on the linked issue. Would you think it would be a good idea to override certain media types with our constants when serving static files to make sure the interpreter's defaults (which may even vary with OS) don't take over?