falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

refactor: implement `get_header_as_int` method #2117

Closed vgerak closed 1 year ago

vgerak commented 1 year ago

Summary of Changes

Implements the get_header_as_int method.

Wasn't sure whether (and how) to document it in the docs, as I couldn't find the part for the similar function get_header_as_datetime().

Related Issues

2060

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2117 (6c94651) into master (44b1596) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 6c94651 differs from pull request most recent head 8bd22bb. Consider uploading reports for the commit 8bd22bb to get more accurate results

@@            Coverage Diff            @@
##            master     #2117   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         5553      5552    -1     
  Branches       880       880           
=========================================
- Hits          5553      5552    -1     
Impacted Files Coverage Δ
falcon/constants.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vgerak commented 1 year ago

@vytas7 pinging issue creator

vytas7 commented 1 year ago

Hi @vgerak! And thanks for this PR, and sorry I've been swamped with other things recently not directly related to Falcon in any way, so I couldn't review in a timely fashion. (If you want to count this towards Hacktoberfest, I've tentatively added the relevant label that should do the job.)

It seems that there are unrelated issues with our CI which must be addressed prior to proceeding with your PR, I'll try to prioritize this when I find some free time.