falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.

https://falcon.readthedocs.io/en/stable/

Apache License 2.0

9.53k stars 945 forks source link

fix(Cython): re-enable cythonization in Cython gates, do not enforce typing #2122

Closed vytas7 closed 2 years ago

vytas7 commented 2 years ago

There is a typing issue in FloatConverter that is causing problems during runtime, and would be detected in mypy too. This is fixed in my typing branch, but I just backported a simple switch not to enforce types in Cython since that has been observed to actually be a de-optimization in most cases.

The problem has been masked by another issue that our Cython gates have PEP 517 disabled in tox, however, the Cython dependency is not installed into these.

codecov[bot] commented 2 years ago

Codecov Report

Merging #2122 (aee6bc6) into master (962d30d) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         5553      5553           
  Branches       880       880           
=========================================
  Hits          5553      5553

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.