search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

3.1.1: tag and branch names are the same #2138

Closed kloczek closed 1 year ago

kloczek commented 1 year ago

Looks like becaue branch has the same name as taf it is not possible to download tagged tar ball

$ wget https://github.com/falconry/falcon//archive/3.1.1/python-falcon-3.1.1.tar.gz
--2023-01-13 04:31:18--  https://github.com/falconry/falcon//archive/3.1.1/python-falcon-3.1.1.tar.gz
Resolving github.com (github.com)... 140.82.121.4, 64:ff9b::8c52:7904
Connecting to github.com (github.com)|140.82.121.4|:443... connected.
HTTP request sent, awaiting response... 300 Multiple Choices
Length: 105 [text/plain]
Saving to: ‘python-falcon-3.1.1.tar.gz’

python-falcon-3.1.1.tar.gz                      100%[====================================================================================================>]     105  --.-KB/s    in 0s

2023-01-13 04:31:18 (9.07 MB/s) - ‘python-falcon-3.1.1.tar.gz’ saved [105/105]

$ cat python-falcon-3.1.1.tar.gz echo
the given path has multiple possibilities: #<Git::Ref:0x00007f68ba9bd668>, #<Git::Ref:0x00007f68ba989d90>cat: echo: No such file or directory

Possible fix: use v<version> convention for tags.

vytas7 commented 1 year ago

Thanks for reporting, yes, it did get slightly suboptimal. I've went for a mirror variant of your suggestion, simply renamed the branch to v3.1.1. https://github.com/falconry/falcon/archive/3.1.1.tar.gz should now unambiguously resolve to https://codeload.github.com/falconry/falcon/tar.gz/refs/tags/3.1.1.