falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

fix(WebSocket): properly handle HTTPStatus and HTTPError cases #2150

Closed CaselIT closed 1 year ago

CaselIT commented 1 year ago

Can you think of further tests to try?

Fixes #2146

codecov[bot] commented 1 year ago

Codecov Report

Merging #2150 (6a2ceba) into master (b16b6c3) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6791      6802   +11     
  Branches      1095      1097    +2     
=========================================
+ Hits          6791      6802   +11     
Impacted Files Coverage Δ
falcon/asgi/app.py 100.00% <100.00%> (ø)
falcon/asgi/ws.py 100.00% <100.00%> (ø)
falcon/util/misc.py 100.00% <100.00%> (ø)
CaselIT commented 1 year ago

thanks. I'll look into adding it and also by the coverage is not happy.

CaselIT commented 1 year ago

thanks for fixing the coverage, I guess the old code was covering that part by chance

CaselIT commented 1 year ago

Thanks!