search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

chore: remove pinning of `importlib-resources` for Mailman tests #2169

Closed vytas7 closed 11 months ago

vytas7 commented 1 year ago

We had to pin importlib-resources for some CI gates because its very aggressive deprecation policy. Now the dependency in question has been dropped upstream, so we don't need to pin anymore (in fact, pinning breaks the gate): https://gitlab.com/mailman/mailman/-/merge_requests/1130.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2169 (ef3031d) into master (0c68df3) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2169   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6830      6830           
  Branches      1098      1098           
=========================================
  Hits          6830      6830
vytas7 commented 1 year ago

Apparently it is still broken, maybe the Docker image needs to be updated :thinking: I'll need to check with @maxking.

vytas7 commented 11 months ago

Closing, it is not as simple as that unfortunately.