falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

feat: type more falcon modules #2171

Closed copalco closed 1 month ago

copalco commented 1 year ago

Summary of Changes

Replace this text with a high-level summary of the changes included in this PR.

Related Issues

Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (3b35eea) to head (e630a2e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2171 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 6849 6889 +40 Branches 1260 1260 ========================================= + Hits 6849 6889 +40 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CaselIT commented 1 year ago

Thanks @copalco for the update, I'll try taking a look by the weekend!

CaselIT commented 1 year ago

I've pushed an update to avoid the imports in the functions, using if TYPE_CHECKING

CaselIT commented 11 months ago

@copalco let us know if you plan on continuing this or if we should take this over the finishing lie. In any case thanks a lot for the effort on this!

copalco commented 11 months ago

@copalco let us know if you plan on continuing this or if we should take this over the finishing lie. In any case thanks a lot for the effort on this!

Sure I can continue. Also I don't mind if you will just propose the actual change as a comment.

CaselIT commented 1 month ago

Will look