Closed CaselIT closed 1 month ago
Moved to draft for now, I'll look at the failure next week.
@vytas7 I don't remember if we settled on installing typing_extensions
on v4 to better support typing
Attention: Patch coverage is 96.26168%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 99.94%. Comparing base (
4910dd7
) to head (9cecfe8
). Report is 73 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
falcon/testing/client.py | 96.19% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
No, I'd love to keep the "production" installation of Falcon free of any dependencies. Is it possible to instruct the type checker to install these extensions?
Also, it is probably OK to add these dependencies on older Python versions. We don't even ship Linux wheels for some of them.
Is it possible to instruct the type checker to install these extensions?
I don't think so.
I'll try doing something more sophisticated wrt import
@CaselIT has this PR been superseded by others in the typing work stream, or should we still consider this one separately?
No, it's still relevant. I plan on finishing it once the other ones are merged
replaced by #2338
Follow up of https://github.com/falconry/falcon/pull/2209 cc @davetapley
Fixes https://github.com/falconry/falcon/issues/2207