Closed nZac closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
9b27c71
) to head (46e542c
).:exclamation: Current head 46e542c differs from pull request most recent head 22844be
Please upload reports for the commit 22844be to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
this was implemented in https://github.com/falconry/falcon/pull/2183
will leave a todo in the code to improve that part
Summary of Changes
Despite the poorly named branch, this PR brings a brings type annotations to the
before
hook. The approach is a proof of concept and I'll welcome suggestions. I've not typed all the functions beneath it, just the top level API though that should be accomplished at some point. See the commit messages for more details.Related Issues
The existing type issues are closed already, so N/A for now.
Pull Request Checklist
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)