falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

refactor: replace `flake8` plugins with `ruff` #2236

Closed CaselIT closed 2 months ago

CaselIT commented 2 months ago

Replace flake8 with ruff

Not 100% sure all the options are the same, but no major changes were required

Fixes #2231

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (c345420) to head (f810b10).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2236 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 6889 6847 -42 Branches 1258 1258 ========================================= - Hits 6889 6847 -42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vytas7 commented 2 months ago

Looks great 💯

Are you sure we are checking the import order though? I remember playing with that, and even when I configured ruff to follow the Google style we are currently using, it still generated a fair diff, and here I see no changes in that 🤔

CaselIT commented 2 months ago

Honestly no, not sure if it activated thwt check

CaselIT commented 2 months ago

Here it goes then