Closed derkweijers closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 36.17%. Comparing base (
89b5fb0
) to head (4dcb8a6
).:exclamation: There is a different number of reports uploaded between BASE (89b5fb0) and HEAD (4dcb8a6). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (89b5fb0) | HEAD (4dcb8a6) | |------|------|------| ||2|1|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ah, it seems we forgot to commit
wslook/.coveragerc
. Do you maybe have the file lying anywhere around @derkweijers?
Yes! Added it to the repo.
I guess I've arrived too late with the review, @vytas7 you mentioned you wanted to cleanup something else, maybe you can incorporate the suggestions?
@derkweijers thanks for the great tutorial, and for participating in the sprint!
@CaselIT yeah, thanks! Just add these suggestions to #2255
Summary of Changes
Add a tutorial on how to work with websockets in a Falcon app. This is to be read as a quickstart, linking to the reference page for more info.
Related Issues
Closes #2240
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.