falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

feat(Response): support Partitioned cookie attribute #2248

Closed M-Mueller closed 2 months ago

M-Mueller commented 2 months ago

Summary of Changes

Allow to set the Partitioned attribute in cookies. Default is not setting it. The changes are very similar to the changes required for the SameSite attribute.

Related Issues

fixes: #2213

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (cd70796) to head (37b29b8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2248 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 6847 6852 +5 Branches 1258 1260 +2 ========================================= + Hits 6847 6852 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CaselIT commented 2 months ago

regarding the too-complex error I think we can suppress it adding # noqa: C901 like in https://github.com/falconry/falcon/blob/09189a85b5b93bef8baa32616a272ceb21293d9b/falcon/routing/compiled.py#L150

CaselIT commented 2 months ago

regarding the too-complex error I think we can suppress it adding # noqa: C901 like in

https://github.com/falconry/falcon/blob/09189a85b5b93bef8baa32616a272ceb21293d9b/falcon/routing/compiled.py#L150

ok you already did that, great!