Open iuliachiriac opened 4 months ago
I submitted this as a draft because I plan on addressing remaining changes in https://github.com/falconry/falcon/issues/1793 in the following days.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
c124e3a
) to head (0b23def
). Report is 42 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi Iuliana, and thanks once again for Sprinting in Prague! Just checking if you are planning to continue on this issue? It looks like it is not that much left here, well done so far! :100:
Hi Iuliana, and thanks once again for Sprinting in Prague! Just checking if you are planning to continue on this issue? It looks like it is not that much left here, well done so far! 💯
Hi Vytautas! Thank you for the opportunity and the guidance! I will get back to it this week, if it't not too late, sorry for the delay!
Summary of Changes
This PR changes
create_req
andcreate_asgi_req
to make their behaviour consistent withsimulate_request
by:content_type
,json
,params
,params_csv
_prepare_sim_args
function (which was also moved tohelpers.py
), which does a series of checks on request attributes and setsContent-Type
extra
argumentRelated Issues
https://github.com/falconry/falcon/issues/1793
Pull Request Checklist
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.