falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.53k stars 945 forks source link

feat(testing): improve `create_req` and `create_asgi_req` #2249

Open iuliachiriac opened 4 months ago

iuliachiriac commented 4 months ago

Summary of Changes

This PR changes create_req and create_asgi_req to make their behaviour consistent with simulate_request by:

Related Issues

https://github.com/falconry/falcon/issues/1793

Pull Request Checklist

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

iuliachiriac commented 4 months ago

I submitted this as a draft because I plan on addressing remaining changes in https://github.com/falconry/falcon/issues/1793 in the following days.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (c124e3a) to head (0b23def). Report is 42 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2249 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 7112 7124 +12 Branches 1260 1264 +4 ========================================= + Hits 7112 7124 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vytas7 commented 2 months ago

Hi Iuliana, and thanks once again for Sprinting in Prague! Just checking if you are planning to continue on this issue? It looks like it is not that much left here, well done so far! :100:

iuliachiriac commented 1 month ago

Hi Iuliana, and thanks once again for Sprinting in Prague! Just checking if you are planning to continue on this issue? It looks like it is not that much left here, well done so far! 💯

Hi Vytautas! Thank you for the opportunity and the guidance! I will get back to it this week, if it't not too late, sorry for the delay!