falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.53k stars 945 forks source link

Deprecate asyncio aliases in `falcon.util` #2253

Closed vytas7 closed 3 months ago

vytas7 commented 4 months ago

I have soft-deprecated them in the docs in https://github.com/falconry/falcon/pull/2252. Emit a deprecation warning in a 4.x release, remove in 5.0. Unless we need them again for, e.g., Trio support (?)

CaselIT commented 4 months ago

the deprecation would use module __getattr__ right?

vytas7 commented 4 months ago

Yes, just like we did with json somewhere. Although in this case we can simply wrap the imported functions with deprecated(...) as well?