falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

refactor(util/sync): deprecate asyncio aliases #2254

Closed bssyousefi closed 1 month ago

bssyousefi commented 2 months ago

Summary of Changes

Deprecating two asyncio aliases (create_task and get_running_loop) used in Falcon.

Related Issues

Fixes #2253

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (cbca63d) to head (864b233).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2254 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 6852 6849 -3 Branches 1260 1260 ========================================= - Hits 6852 6849 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.