search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

feat(typing): type App classes #2286

Closed CaselIT closed 1 month ago

CaselIT commented 1 month ago

This is a follow up of ##2271

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (e5ada2f) to head (9ed7475). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2286 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 63 63 Lines 7330 7410 +80 Branches 1276 1278 +2 ========================================= + Hits 7330 7410 +80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CaselIT commented 1 month ago

sorry for the force push + squash, but it was starting to become a mess

CaselIT commented 1 month ago

Thanks, LGTM now bar these triple ''' docstrings, I regret even starting that discussion 🤣

I actually think it's a lot nicer for reading the source code. Having to escape the """ is quite ugly