search

falconry / falcon

The no-magic web data plane API and microservices framework for Python developers, with a focus on reliability, correctness, and performance at scale.
https://falcon.readthedocs.io/en/stable/
Apache License 2.0
9.51k stars 937 forks source link

fix(test_static.py): fix Windows CPython 3.13 build #2346

Closed vytas7 closed 3 days ago

vytas7 commented 3 days ago

The codebase now builds and passes tests on Windows and CPython 3.13: https://github.com/falconry/falcon/actions/runs/11082068662/job/30794594018.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (217dc46) to head (925186b). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2346 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 64 64 Lines 7621 7621 Branches 1244 1244 ========================================= Hits 7621 7621 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CaselIT commented 3 days ago

Not sure why the change ls fixes it, but it looks fine

vytas7 commented 3 days ago

Not sure why the change ls fixes it, but it looks fine

Because we use a specialized client fixture that does some absolute path mangling for CPython 3.13 on Windows. Same issue as before.

I also extended the wheels test from just emulated to also build Windows, Mac and musllinux, so that we can easier catch these regressions later.

CaselIT commented 3 days ago

Oh interesting. Ok