search

falconry / python-mimeparse

Basic functions for handling Internet media types in Python.
MIT License
19 stars 11 forks source link

cgi deprecation #48

Closed rafalkrupinski closed 2 weeks ago

rafalkrupinski commented 3 months ago

Hi guys, python 3.13 is in beta now. Any chance to release a version with the dependency on cgi removed?

vytas7 commented 3 months ago

Yes, we'll try to get out a new version before 3.13 is released.

CaselIT commented 3 months ago

is the plan to vendor the functions from the cgi module used like it was done in falcon?

gorilla-seb commented 2 weeks ago

Seems like the function was already vendored in, https://github.com/falconry/python-mimeparse/blob/master/mimeparse.py#L27-L47

All it takes now is someone to bump the version and release..

vytas7 commented 2 weeks ago

Hi @gorilla-seb, yes, we'll try to get out a release shortly.

Falcon had some checks in the CI to verify that we were vendoring the latest version, I will need to temporarily (or permanently if we decide to reimplement what we need) disable these checks for the impending release of this project.

vytas7 commented 2 weeks ago

Hi again @gorilla-seb & @rafalkrupinski! This issue is now closed, and I have released 2.0.0rc1 to PyPI.

Please take it for a spin with your projects:

pip install python-mimeparse==2.0.0rc1

Unless we run into any serious issues, I'll cut 2.0.0 stable later.

rafalkrupinski commented 2 weeks ago

My tests pass with the RC.

I only use best_match

vytas7 commented 1 week ago

Thanks for checking, @rafalkrupinski! I have now cut a stable release, python-mimeparse v2.0, so you can update your dependencies.

gorilla-seb commented 1 week ago

Looks to be working fine, many thanks @vytas7!