falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
239 stars 285 forks source link

feat(falco-exporter): added ability to set the grafana folder annotation name #654

Closed dotdc closed 5 months ago

dotdc commented 5 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-exporter-chart

What this PR does / why we need it:

This PR adds the ability to set the grafana folder annotation name used by the Grafana sidecar. This is useful when using folderAnnotation in the Grafana Helm Chart. Set the default value to the previously hardcoded one.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Checklist

poiana commented 5 months ago

Welcome @dotdc! It looks like this is your first PR to falcosecurity/charts 🎉

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: be671b5885f8f98acd2d322e09b712563427d403

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, dotdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment