falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
230 stars 280 forks source link

feat: updated grafana dashboard #657

Closed dotdc closed 2 months ago

dotdc commented 3 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-exporter-chart

What this PR does / why we need it:

Updated the Falco Grafana dashboard ito make it more user friendly and removed deprecated panels since Grafana 7 (2020). All details in https://github.com/falcosecurity/charts/issues/656

Which issue(s) this PR fixes:

Fixes #656

Special notes for your reviewer:

Checklist

dotdc commented 2 months ago

The dashboard seems good to me, I just can't explain we have commentary in some of the expressions. See my comments. Once removed, I'll approve it.

Yes, this was debug data, should be all good now.

poiana commented 2 months ago

LGTM label has been added.

Git tree hash: f3044fdc7114451dbb3afe7c8122f43fe376ce16

Issif commented 2 months ago

Please resolve the conflicts.

dotdc commented 2 months ago

@Issif done

poiana commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dotdc, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 2 months ago

LGTM label has been added.

Git tree hash: 54d99ae8e036c271237757cd44f80578a16eea12