search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
239 stars 285 forks source link

8f63167 CHART: add additionalProperties for falco-exporter service Monitor #662

Closed ArnaudCHT closed 5 months ago

ArnaudCHT commented 5 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: I've added the capability to the Falco-exporter charts to set additional properties within the Service Monitor, such as relabelings, metricRelabelings, etc. I ran a Helm template and tested the Service Monitor in an OpenShift cluster.

commit : 8f6316779caea99066e2e535d8b0b7df5dba7650

Checklist

poiana commented 5 months ago

Welcome @ArnaudCHT! It looks like this is your first PR to falcosecurity/charts 🎉

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: aa9a65091187e1d4c4710708a7a07240e4b586e0

Issif commented 5 months ago

Can you sign off your commits and run make docs to format the readme as expected please.

ArnaudCHT commented 5 months ago

Hello, I sign off the commits and run make docs. Thanks.

Issif commented 5 months ago

This DCO is still wrong, are you sure having signed off the commit?

ArnaudCHT commented 5 months ago

My bad. This should be OK now !

poiana commented 5 months ago

LGTM label has been added.

Git tree hash: 0efa28ea0a15d5c4385ee1203cb5fbf399d83929

poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArnaudCHT, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment