falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
239 stars 285 forks source link

feat : falcosidekick service monitor update add aditionnal properties #670

Closed ArnaudCHT closed 4 months ago

ArnaudCHT commented 4 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: I run a helm template, helm lint helm dry-run to test and try the serviceMonitor on Openshift cluster. Test the prometheusRule on grafana.

Checklist

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArnaudCHT, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 879fb4e853ab9a745da22a6a9679084717753fc0