search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
230 stars 280 forks source link

Fix existing client secret check #676

Closed orange-llajeanne closed 1 month ago

orange-llajeanne commented 1 month ago

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falco-chart

What this PR does / why we need it:

This PR fixes a check in the falco pod template, which uses the existingSecret variable instead of existingClientSecret when deciding if client secrets are enabled.

The consequence was that the chart would not work correctly when defining existingSecret but not existingClientSecret: it would try to attach an unexisting configmap to falco pods

Checklist

poiana commented 1 month ago

Welcome @orange-llajeanne! It looks like this is your first PR to falcosecurity/charts 🎉

alacuku commented 1 month ago

Hi @orange-llajeanne, thanks for the PR. Could you please rebase on main?

orange-llajeanne commented 1 month ago

@alacuku Hi, I've rebased my branch and updated the version number

alacuku commented 1 month ago

@orange-llajeanne, it would help if you run a make docs, and then we can merge it.

poiana commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, orange-llajeanne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 1 month ago

LGTM label has been added.

Git tree hash: f1a67d6f4487f65d658fe3cac7509629a1b6cc99