Feat: add extra labeling capabilities for falco daemonset/deployment

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes

Apache License 2.0

239 stars 285 forks source link

Feat: add extra labeling capabilities for falco daemonset/deployment #684

Closed Strigix closed 3 months ago

Strigix commented 4 months ago

/kind feature

/kind chart-release

/area falco-chart

What this PR does / why we need it:

This PR adds an extra field: controller.labels which allows users to set extra labels for the Falco daemonset/deployment.

[X] Chart Version bumped
[ ] Variables are documented in the README.md
[X] CHANGELOG.md updated

poiana commented 4 months ago

Welcome @Strigix! It looks like this is your first PR to falcosecurity/charts 🎉

alacuku commented 3 months ago

Please, run make docs to update the docs.

alacuku commented 3 months ago

@Strigix, can you bump the chart version and then run make docs? It should make the CI happy.

Strigix commented 3 months ago

@alacuku I Hadn't realised it went up another version! Bumped and reran make docs :) Thanks for the headsup.

alacuku commented 3 months ago

hey @Strigix, could you squash your commits? Once you've done it, we are ready to merge it.

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, Strigix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

poiana commented 3 months ago

LGTM label has been added.

Git tree hash: eabfb6f77a0cc5479ec54e77707f10337fe5f69e