falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
230 stars 280 forks source link

Fix wrong WEBUI_URL since #685 #687

Closed Sryther closed 1 month ago

Sryther commented 1 month ago

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

Wrong WEBUI_URL value since #685.

Example:

# helm template -s templates/secrets.yaml . | yq '.data.WEBUI_URL|@base64d'
http://release-name-falcosidekick-ui:%!s(float64=2802)

Should be:

# helm template -s templates/secrets.yaml . | yq '.data.WEBUI_URL|@base64d'
http://release-name-falcosidekick-ui:2802

Which issue(s) this PR fixes:

Fixes #686

Special notes for your reviewer:

Checklist

poiana commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, Sryther

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 1 month ago

LGTM label has been added.

Git tree hash: 5484eccba593a6e7200d377b0b62b806b9414f49