falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
239 stars 285 forks source link

Create PodMonitor or ServiceMonitor for Falco #692

Closed ctdfo closed 2 months ago

ctdfo commented 3 months ago

Motivation Falco exposes a metrics endpoint through its webserver, but there's no PodMonitor or ServiceMonitor configured for Prometheus to scrape the metrics from the endpoint.

Feature Add a PodMonitor and/or ServiceMonitor for Prometheus to scrape the metrics from the metrics endpoint.

Alternatives N/A

Additional context The prometheus_metrics_enabled value in the Falco chart is a bit misleading since it only allows to expose the metrics but doesn't enable Prometheus to scrape those metrics. Also, there's a ServiceMonitor already configured in the charts for falcosidekick, falco-exporter and k8s-metacollector. image

alacuku commented 3 months ago

Hi @ctdfo, we have a tracking issue for the grafana dashboard and metrics support in the charts:https://github.com/falcosecurity/cncf-green-review-testing/issues/12

jemag commented 3 months ago

thanks for the info @alacuku . Hopefully we can still keep this one open, since it's easier to track/find for users of the helm chart.

alacuku commented 2 months ago

Hey @ctdfo, @jemag the support for Falco metrics has been merged: https://github.com/falcosecurity/charts/pull/700