search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
239 stars 285 forks source link

Update securitycontextconstraints.yaml #694

Closed toamto94 closed 3 months ago

toamto94 commented 3 months ago

ordered volume list in falco scc yaml alphabetically

What type of PR is this?

/kind bug

/kind chart-release

/area falco-chart

What this PR does / why we need it: Making the helm chart more robust by re-ordering configuration in the falco helm chart scc yaml

Which issue(s) this PR fixes: Sync errors in ArgoCD as a result of the unordered list which is ordered by the kube-api alphabetically. Argo then compares plain yaml and fails

Fixes #693

Special notes for your reviewer:

Checklist

poiana commented 3 months ago

Welcome @toamto94! It looks like this is your first PR to falcosecurity/charts 🎉

Issif commented 3 months ago

Thanks @toamto94,

To be valid, your changes must come with a bump of the chart version and an update of changelog.

toamto94 commented 3 months ago

changelog and chart bump has been added

alacuku commented 3 months ago

Hey @toamto94, could you update the docs by running make docs?

toamto94 commented 3 months ago

Hey @toamto94, could you update the docs by running make docs?

done :)

poiana commented 3 months ago

LGTM label has been added.

Git tree hash: 5fa9ff93775c6499a0c67203122a24f32e78b3d0

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, toamto94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment