falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
230 stars 280 forks source link

Expose AWS_S3_ENDPOINT configuration #697

Closed gysel closed 3 weeks ago

gysel commented 3 weeks ago

What type of PR is this?

/kind documentation /kind feature

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

Expose configuration option added with https://github.com/falcosecurity/falcosidekick/pull/791.

poiana commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gysel Once this PR has been reviewed and has the lgtm label, please assign issif for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 3 weeks ago

Welcome @gysel! It looks like this is your first PR to falcosecurity/charts 🎉

alacuku commented 3 weeks ago

Hi @gysel, thanks for the PR. Please, have a look to the contributing section in the docs: https://github.com/falcosecurity/charts#contributing

Issif commented 3 weeks ago

Hi,

The release 2.29.0 of Falcosidekick is scheduled for next week, I already prepared the upgrade of the Helm chart and it contains the change you propose: https://github.com/falcosecurity/charts/pull/696

Regards,

gysel commented 3 weeks ago

@Issif - excellent, thanks!