falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
246 stars 291 forks source link

feat(falcosidekick): allow to set resources, securityContext and image overwrite for wait-redis initContainer #703

Closed tberreis closed 4 months ago

tberreis commented 4 months ago

What type of PR is this?

/kind feature

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it: If someone wants to define resource limits or a security context for the wait-redis init container, this change can be useful. The default values are empty and therefore this change won't break any existing setup. It also allows the user to update or replace the busybox image.

Setting resource limits and security contexts are forced in many organizations, e.g. by using checkov and gatekeeper policies.

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

Checklist

Issif commented 4 months ago

Another PR #702 has been created to allow to chose the image. yours contain more changes so I'll merge this one. An update of the dependency is the falco helm chart will have to be done after

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, tberreis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 476e46ceb84e4bc41222cd59d58c208ae685069d

tberreis commented 4 months ago

Another PR #702 has been created to allow to chose the image. yours contain more changes so I'll merge this one. An update of the dependency is the falco helm chart will have to be done after

Ah sorry. Didn't see the PR. Thank you for that ultra fast review.