falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
230 stars 280 forks source link

[fix] Helm : Grafana dashboard for k8s metacollector #705

Open nlamirault opened 2 weeks ago

nlamirault commented 2 weeks ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

/area event-generator-chart

/area k8s-metacollector

What this PR does / why we need it:

Before PR:

Falco-Meta-Collector-security-Dashboards-Grafana

After:

Falco-Meta-Collector-security-Dashboards-Grafana (1)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

Issif commented 1 week ago

Hi,

To make this PR valid for the CI, please:

Also, be sure to have rebased on master before and squashed your commits.

alacuku commented 1 week ago

Hi @nlamirault, thanks for the contribution!

Please, update the chart version, docs, and changelog. Once you have done we can merge the changes.

poiana commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlamirault Once this PR has been reviewed and has the lgtm label, please ask for approval from issif. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alacuku commented 4 days ago

hi @nlamirault, could you please rebase your branch on top of main?

poiana commented 4 days ago

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository. Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.