falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
246 stars 291 forks source link

Make 'for' configurable for falco exporter prometheus rules #707

Closed jochbru closed 4 months ago

jochbru commented 4 months ago

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area falco-exporter-chart

What this PR does / why we need it:

This PR makes the for field configurable within the helm values.

Which issue(s) this PR fixes:

N/a

poiana commented 4 months ago

Welcome @TheChef23! It looks like this is your first PR to falcosecurity/charts 🎉

Issif commented 4 months ago

Hi,

to have a valid PR, you have to update the changelog, bump up the chart version and run make docs-falco-exporter.

[!WARNING] The falco-exporter will be deprecated in the next months, Falco now exposes a metrics endpoint

jochbru commented 4 months ago

Hi,

to have a valid PR, you have to update the changelog, bump up the chart version and run make docs-falco-exporter.

Warning

The falco-exporter will be deprecated in the next months, Falco now exposes a metrics endpoint

Hi,

I've run the make command and bumped the version.

jochbru commented 4 months ago

Excusez moi, fixed.

jochbru commented 4 months ago

Last point, could you rebase on master and squash your commits please

Done, thanks for your patience!

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, TheChef23

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 6cba12315e3096dec6f5f273be4a51020fd0eda4