search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
239 stars 285 forks source link

Fix redis-availability check in UI #710

Closed jegger closed 2 months ago

jegger commented 2 months ago

What type of PR is this?

/kind bug /kind chart-release

Any specific area of the project related to this PR? /area falco-chart /area falcosidekick-chart

Which issue(s) this PR fixes: It fixes the redis-availability check of the UI init-container in case external-redis is enabled. It was using the hard-coded value used when you would not use an exernal-redis.

I also upgraded the chart-version of the sidekick and flaco to get the fix also into the falco chart. It would certainly support the use I have - but I don't know if bumping two versions at once is something you do. Let me know.

poiana commented 2 months ago

Welcome @jegger! It looks like this is your first PR to falcosecurity/charts 🎉

poiana commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Issif, jegger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 2 months ago

LGTM label has been added.

Git tree hash: 86a30a86f29ff4e520fc4036e84e439f6c07a14d