search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
246 stars 291 forks source link

fix: mount client-certs-volume only if certs.existingClientSecret is … #716

Closed yohboy closed 4 months ago

yohboy commented 4 months ago

…defined

What type of PR is this? /kind bug

Any specific area of the project related to this PR? /area falco-chart

What this PR does / why we need it:

Fix a bug where the chart tries to mount a volume that does not exist.
The check to mount the volume is wrong and should check for the .Values.certs.existingClientSecret value instead of .Values.certs.existingSecret.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Checklist

poiana commented 4 months ago

Welcome @yohboy! It looks like this is your first PR to falcosecurity/charts 🎉

yohboy commented 4 months ago

/kind bug

yohboy commented 4 months ago

/area falco-chart

alacuku commented 4 months ago

Hi @yohboy, please run make docs to update the chart version in the docs.

yohboy commented 4 months ago

Hi @alacuku , done ✅ Thanks

poiana commented 4 months ago

LGTM label has been added.

Git tree hash: 1ac2e015a528eafd5acb09f199c4765f98a7ca0f

alacuku commented 4 months ago

/approve

poiana commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, yohboy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [alacuku] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment