search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
245 stars 290 forks source link

fix(falcosidekick): add support for custom service type for webui redis in Helm chart #730

Closed dbeilin closed 3 months ago

dbeilin commented 3 months ago

What type of PR is this?

/kind bug

/kind chart-release

Any specific area of the project related to this PR?

/area falcosidekick-chart

What this PR does / why we need it:

This PR fixes an issue in the Helm chart where the WebUI Redis service type was hardcoded to ClusterIP, ignoring the user-configured value under webui.redis.service.type.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

poiana commented 3 months ago

Welcome @dbeilin! It looks like this is your first PR to falcosecurity/charts 🎉

dbeilin commented 3 months ago

Hello, I was trying to expose the web UI Redis to my other clusters by settings the Type to LoadBalancer but noticed that it ignores my values file even though the documentation already says it's supported: webui.redis.service.type.

I'm not too familiar with contributing to projects but this is a small fix, hoping I didn't miss anything :)

Issif commented 3 months ago

Hi @dbeilin,

I just came back from holidays Yesterday, I'm catching up what I missed by FIFO order, I'll review your PR asap.

dbeilin commented 3 months ago

thank you @Issif , appreciate your help! I was just about to deploy a local chart so the timing is great 😄

dbeilin commented 3 months ago

@Issif - hello Thomas. any ETA on this PR?

Thanks

poiana commented 3 months ago

LGTM label has been added.

Git tree hash: e6e0fb28c3a71152aa9fd21596ca456dd4dbe8e1

poiana commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dbeilin, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)~~ [Issif] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Issif commented 3 months ago

Approved. You also need to bump up the dep in the falco chart now.

dbeilin commented 3 months ago

@Issif Thanks, opened a PR to bump it: https://github.com/falcosecurity/charts/pull/731 Hope it's ok.