search

falcosecurity / charts

Community managed Helm charts for running Falco with Kubernetes
Apache License 2.0
245 stars 290 forks source link

Refactor falco talon chart #765

Open leofvo opened 1 month ago

leofvo commented 1 month ago

What type of PR is this? /kind cleanup /kind feature /kind chart-release

Any specific area of the project related to this PR? /area falco-talon

What this PR does / why we need it: I added support of name and namespace override for falco-talon as Falco is doing. I added support for falco-talon custom rules. I found an issue that i wasn't able to custom talon rules due to a little mistake in the chart, after discussion with a maintainer, we have agreed to change this behavior to support it as Falco does.

Which issue(s) this PR fixes: Fixes #https://github.com/falcosecurity/falco-talon/issues/491#issuecomment-2414710722

Special notes for your reviewer: This is my first contribution to Falco, don't hesitate to give me feedbacks if I can improve my proposals.

Checklist

poiana commented 1 month ago

@LeoFVO: The label(s) area/falco-talon cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/falcosecurity/charts/pull/765): >**What type of PR is this?** >/kind cleanup >/kind feature >/kind chart-release > >**Any specific area of the project related to this PR?** >/area falco-talon > >**What this PR does / why we need it**: >I added support of name and namespace override for falco-talon as Falco is doing. >I added support for falco-talon custom rules. I found an issue that i wasn't able to custom talon rules due to a little mistake in the chart, after discussion with a maintainer, we have agreed to change this behavior to support it as Falco does. > > >**Which issue(s) this PR fixes**: >Fixes #https://github.com/falcosecurity/falco-talon/issues/491#issuecomment-2414710722 > >**Special notes for your reviewer**: >This is my first contribution to Falco, don't hesitate to give me feedbacks if I can improve my proposals. > >**Checklist** >- [ ] Chart Version bumped >- [ ] Variables are documented in the README.md >- [ ] CHANGELOG.md updated > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
poiana commented 1 month ago

Welcome @LeoFVO! It looks like this is your first PR to falcosecurity/charts 🎉

poiana commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LeoFVO Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/charts/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
leofvo commented 1 month ago

Hey, this PR is fixing some issues I noticed here

I also improved the codebase to be more uniformized with falco charts. If you have any questions, feel free to ask :)

Issif commented 1 month ago

I'm currently in Norway for a talk, will review asap. Thanks a lot.