search

falcosecurity / deploy-kubernetes

Kubernetes deployment resources for Falco
Apache License 2.0
11 stars 16 forks source link

update(kubernetes): Update manifests files template falcosidekick #113

Closed chacoex closed 4 months ago

chacoex commented 5 months ago

Updating manifests falcosidekick files (automatically generated by helm template)

/kind update /area manifests

Fixes # al apply "kubectl apply -k falcosidekick"
generate error: mapping key "app.kubernetes.io/component: core " already defined the app.kubernetes.io/component: core is repeat

poiana commented 5 months ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
poiana commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chacoex Once this PR has been reviewed and has the lgtm label, please assign maxgio92 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/falcosecurity/deploy-kubernetes/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 5 months ago

Welcome @chacoex! It looks like this is your first PR to falcosecurity/deploy-kubernetes 🎉

Issif commented 4 months ago

The labels for the falcosidekick deployment have been fixed in some recent PR. We can close this PR.

leogr commented 4 months ago

The labels for the falcosidekick deployment have been fixed in some recent PR. We can close this PR.

I didn't know that. So, I agree we can close it. /close

@chacoex Anyway, feel free to reopen it if we are missing anything. Thanks.

poiana commented 4 months ago

@leogr: Closed this PR.

In response to [this](https://github.com/falcosecurity/deploy-kubernetes/pull/113#issuecomment-2020949307): >> The labels for the falcosidekick deployment have been fixed in some recent PR. We can close this PR. > >I didn't know that. So, I agree we can close it. >/close > >@chacoex Anyway, feel free to reopen it if we are missing anything. Thanks. > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.