search

falcosecurity / deploy-kubernetes

Kubernetes deployment resources for Falco
Apache License 2.0
11 stars 16 forks source link

update(docs): add more details to kubernetes readme #96

Closed incertum closed 7 months ago

incertum commented 7 months ago

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind update

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area manifests

/area documentation

What this PR does / why we need it:

Update docs for Kubernetes deployment to provide more details and add a note around what to keep in mind when testing this with minikube as I experienced some hiccups there.

@leogr @maxgio92

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

poiana commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: incertum, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/falcosecurity/deploy-kubernetes/blob/main/OWNERS)~~ [leogr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
poiana commented 7 months ago

LGTM label has been added.

Git tree hash: 36b07d78b0100797bf4da90152a939290dd784b7